Fix wchar deserialize error when swaping the bytes

[hwwei521]

After downloading the latest Fast-CDR, I verified Fast-CDR's functionality by following the steps below：

git clone https://github.com/eProsima/Fast-CDR.git

cd Fast-CDR

mkdir build && cd build

cmake .. -DCMAKE_INSTALL_PREFIX=../install -D BUILD_TESTING=ON -D GTest_DIR=/usr/local

cmake --build . --target install

./test/cdr/UnitTests 

When I wanted to test the performance in the case of CDR swap, I changed the Cdr cdr_ser(cdrbuffer) and Cdr cdr_des(cdrbuffer) of the TEST(CDRTests, Complete) test entry to Cdr cdr_ser(cdrbuffer, eprosima::fastcdr::Cdr::Endianness::BIG_ENDIANNESS) and Cdr cdr_des(cdrbuffer, eprosima::fastcdr::Cdr::Endianness::BIG_ENDIANNESS) respectively. To make the test and the current test environment default processor Endianness inconsistent, forced to trigger the processing of CDR swap, found in EXPECT_EQ (wcscmp(c_wstring_t, c_wstring_value), 0) reported an error.

I found that swap is not considered in the Cdr& Cdr::serialize(wchar_t*& string_t) function, so I replaced it with deserialize_array(string_t, length), and it works fine.

[hwwei521]

This seems work fine

[richiprosima]

Build status:

• Linux
• Mac
• Windows

[hwwei521]

@richiprosima Hi richiprosima,
Can you help review the code and allow patch submissions?
This patch will fix issues #185.

[JLBuenoLopez]

@hwwei521

Please be patient. Currently most of eProsima developers are in holiday vacations. We will review your contribution in the next few weeks. Sorry for the wait.

[JesusPoderoso]

Hi @hwwei521 thank you for using Fast DDS and for your contribution!

When I wanted to test the performance in the case of CDR swap, I changed the Cdr cdr_ser(cdrbuffer) and Cdr cdr_des(cdrbuffer) of the TEST(CDRTests, Complete) test entry to Cdr cdr_ser(cdrbuffer, eprosima::fastcdr::Cdr::Endianness::BIG_ENDIANNESS) and Cdr cdr_des(cdrbuffer, eprosima::fastcdr::Cdr::Endianness::BIG_ENDIANNESS) respectively. To make the test and the current test environment default processor Endianness inconsistent, forced to trigger the processing of CDR swap, found in EXPECT_EQ (wcscmp(c_wstring_t, c_wstring_value), 0) reported an error.

Could you include another commit with a regression test including the way you test it (as you have described above) to keep track of it?

[hwwei521]

Hi @hwwei521 thank you for using Fast DDS and for your contribution!

When I wanted to test the performance in the case of CDR swap, I changed the Cdr cdr_ser(cdrbuffer) and Cdr cdr_des(cdrbuffer) of the TEST(CDRTests, Complete) test entry to Cdr cdr_ser(cdrbuffer, eprosima::fastcdr::Cdr::Endianness::BIG_ENDIANNESS) and Cdr cdr_des(cdrbuffer, eprosima::fastcdr::Cdr::Endianness::BIG_ENDIANNESS) respectively. To make the test and the current test environment default processor Endianness inconsistent, forced to trigger the processing of CDR swap, found in EXPECT_EQ (wcscmp(c_wstring_t, c_wstring_value), 0) reported an error.

Could you include another commit with a regression test including the way you test it (as you have described above) to keep track of it?

Hi, Jesús
You want me to submit a patch of the program I was testing at the time to do a regression test right?
I was doing the test as below, and if I need to submit a patch for regression testing, I'll submit another patch later for regression test validation use.

git clone https://github.com/eProsima/Fast-CDR.git

cd Fast-CDR

mkdir build && cd build

cmake .. -DCMAKE_INSTALL_PREFIX=../install -D BUILD_TESTING=ON -D GTest_DIR=/usr/local

cmake --build . --target install

./test/cdr/UnitTests 

[JesusPoderoso]

Hi Hanwuwei, I meant including a test like this one in the test suite, where we can try to run with and without your fix to check that is solves it.

[hwwei521]

Hi Hanwuwei, I meant including a test like this one in the test suite, where we can try to run with and without your fix to check that is solves it.

Hi, Jesús
I update another patch #189, Please help to check.
#189
The test result as the file show
UnitTests_reports.txt

[richiprosima]

Build status:

• Linux
• Mac
• Windows

[hwwei521]

@JesusPoderoso
Hi, Jesús, The simple regression test patch added in #190

[MiguelCompany]

I rebased this on top of master, and included the test from #190

[richiprosima]

Build status:

• Linux
• Mac
• Windows

[richiprosima]

Build status:

• Linux
• Mac
• Windows

[MiguelCompany]

Going in. Thank you @hwwei521 for your contribution!