Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20414] Add PR template #203

Merged
merged 3 commits into from
Jul 9, 2024
Merged

[20414] Add PR template #203

merged 3 commits into from
Jul 9, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Feb 26, 2024 •
edited by EduPonz
Loading

Description

This PR adds this PR template

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.

@JesusPoderoso JesusPoderoso added the needs-review Mark this PR as ready to be reviewed label Feb 26, 2024
@JesusPoderoso JesusPoderoso self-assigned this Feb 26, 2024
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@EduPonz EduPonz added this to the v2.2.1 milestone Feb 29, 2024
@MiguelCompany MiguelCompany modified the milestones: v2.2.1, v2.2.2 Mar 26, 2024
EduPonz
EduPonz suggested changes May 14, 2024
View reviewed changes
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@JesusPoderoso JesusPoderoso added ci-pending and removed needs-review Mark this PR as ready to be reviewed labels May 14, 2024
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

EduPonz
EduPonz suggested changes May 14, 2024
View reviewed changes
.github/pull_request_template.md Outdated Show resolved Hide resolved
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@JesusPoderoso JesusPoderoso added needs-review Mark this PR as ready to be reviewed and removed ci-pending labels Jun 6, 2024
@EduPonz EduPonz modified the milestones: v2.2.2, v2.2.3 Jun 21, 2024
@JesusPoderoso
Refs #20414: Add PR template
dd89db7 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #20414: Apply rev suggestions
8adb6ff 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #20414: Apply rev suggestions (2)
c79f366 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso mentioned this pull request Jul 1, 2024
Closed
7 tasks
@EduPonz EduPonz added ready-to-merge and removed needs-review Mark this PR as ready to be reviewed labels Jul 9, 2024
@EduPonz EduPonz merged commit 88d524b into master Jul 9, 2024
5 of 7 checks passed
@EduPonz EduPonz deleted the feature/pr_template branch July 9, 2024 08:28
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@JesusPoderoso JesusPoderoso mentioned this pull request Jul 11, 2024
Merged
7 tasks
@mergify mergify bot mentioned this pull request Jul 11, 2024
Merged
7 tasks
This was referenced Jul 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge
Projects
None yet
Milestone
v2.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@JesusPoderoso @richiprosima @EduPonz @MiguelCompany