Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #5433 Avoid const decl from included files being declared twice. [5445] #49

Merged
merged 1 commit into from
May 27, 2019
Merged

Refs #5433 Avoid const decl from included files being declared twice. [5445] #49

merged 1 commit into from
May 27, 2019

Conversation

LuisGP
Copy link
Contributor

@LuisGP LuisGP commented May 20, 2019 •
edited by MiguelCompany
Loading

@LuisGP LuisGP changed the title Refs #5433 Avoid const decl from included files being declared twice. Refs #5433 Avoid const decl from included files being declared twice. [5445] May 20, 2019
@LuisGP LuisGP mentioned this pull request May 20, 2019
Closed
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany requested changes May 27, 2019
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test should be added to check the correct behavior

@LuisGP
Copy link
Contributor Author

LuisGP commented May 27, 2019

A test should be added to check the correct behavior

The test should be added to IDL-Parser, which stores the IDL files used to test Fast-RTPS-Gen.

@MiguelCompany MiguelCompany merged commit 906c966 into master May 27, 2019
@MiguelCompany MiguelCompany deleted the hotfix/included_const_decl branch May 27, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fastrtpsgen: example generation copies consts from a msg to another that uses a builtin type [5433]
3 participants
@LuisGP @richiware @MiguelCompany