Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21538] Allow all durability configurations #907

Merged
merged 3 commits into from
Oct 3, 2024
Merged

[21538] Allow all durability configurations #907

merged 3 commits into from
Oct 3, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Sep 12, 2024 •
edited by MiguelCompany
Loading

Description

This PR documents the new behavior included in the implementation PR:

  • Allows the creation of a DataWriter/Reader with a PERSISTENT durability, but behaving as TRANSIENT (warning about it).
  • When in TRANSIENT, if no persistence guid is given, it fallbacks to TRANSIENT_LOCAL.

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL Mario-DL added this to the v3.1.0 milestone Sep 12, 2024
@Mario-DL Mario-DL mentioned this pull request Sep 12, 2024
Merged
14 tasks
MiguelCompany
MiguelCompany requested changes Sep 20, 2024
View reviewed changes
docs/fastdds/persistence/persistence.rst Outdated Show resolved Hide resolved
docs/fastdds/dds_layer/core/policy/standardQosPolicies.rst Outdated Show resolved Hide resolved
docs/fastdds/persistence/persistence.rst Outdated Show resolved Hide resolved
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for richiprosima and MiguelCompany September 23, 2024 10:22
@MiguelCompany MiguelCompany self-requested a review October 2, 2024 05:59
@Mario-DL
Refs #21538: Specify new PERSISTENT behavior and TRANSIENT with no pe…
38fdffb 
…rsistence guid

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21538: Apply Miguels review
e9db9fb 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21538: Apply last suggestion
0a55a50 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany October 2, 2024 06:32
@MiguelCompany MiguelCompany merged commit 782514c into master Oct 3, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/21538 branch October 3, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany Awaiting requested review from MiguelCompany

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany