[20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
10 tasks
10 tasks
|
@Mergifyio rebase |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4187
branch
from
33c5635
to
f461306
Compare
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4187
branch
from
f461306
to
bb920aa
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4187
branch
from
295a0d1
to
819ba6f
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
|
Depends on #4795. Should be merged after it. |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4187
branch
from
819ba6f
to
3549d8b
Compare
MiguelCompany
removed
the
temporarily-blocked
|
@Mergifyio rebase |
… samples (#4187) * Refs #20162. Regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Notify sample lost when dropping fragmented change. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20167. Linters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Apply suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Use constexpr for buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Lower buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20351. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5ac198e)
* Refs #20692. Make sample_lost_be_dw_be_dr_fragments test less flakey. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20692. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4187
branch
from
3549d8b
to
7ee8510
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
|
@richiprosima Please test this |
|
@richiprosima please test mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When some fragments are lost on every sample, best-effort readers were not notifying
on_sample_lostevents.@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4187 done by [Mergify](https://mergify.com).