Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20765] Make RTPS reader implementations private #4674

Merged
merged 6 commits into from
May 27, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 9, 2024

Description

This PR makes RTPS reader implementations private:

  • StatefulPersistentReader
  • StatefulReader
  • StatelessPersistentReader
  • StatelessReader

Related PR in Fast DDS Python:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Apr 9, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Apr 9, 2024
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 3 times, most recently from 5148f5d to bd83bb2 Compare April 23, 2024 05:52
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 08ee62b to 623db82 Compare May 13, 2024 09:26
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:28
@elianalf elianalf force-pushed the feature/make_rtps_reader_impl_private branch from f23b852 to 3bbc297 Compare May 14, 2024 13:38
@elianalf elianalf requested a review from EduPonz May 14, 2024 13:39
@github-actions github-actions bot added ci-pending PR which CI is running labels May 14, 2024
@MiguelCompany
Copy link
Member

@elianalf There are conflicts here, so a rebase is necessary.

@MiguelCompany MiguelCompany added needs rebase and removed ci-pending PR which CI is running labels May 24, 2024
elianalf added 2 commits May 24, 2024 11:04
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to also change the extension of the moved headers from .h to `.hpp

src/cpp/rtps/reader/StatefulReader.h Outdated Show resolved Hide resolved
elianalf added 2 commits May 24, 2024 11:09
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/make_rtps_reader_impl_private branch from 3bbc297 to fc47457 Compare May 24, 2024 09:14
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/make_rtps_reader_impl_private branch from 01662e8 to f47830e Compare May 24, 2024 09:56
@elianalf elianalf requested a review from MiguelCompany May 24, 2024 09:59
@elianalf elianalf removed needs-review PR that is ready to be reviewed needs rebase labels May 24, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 24, 2024
src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/participant/RTPSParticipantImpl.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/reader/StatefulPersistentReader.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/reader/StatefulReader.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/reader/StatelessPersistentReader.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/reader/StatelessReader.hpp Show resolved Hide resolved
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@MiguelCompany MiguelCompany self-requested a review May 27, 2024 06:47
@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@MiguelCompany MiguelCompany merged commit 0023800 into master May 27, 2024
12 of 15 checks passed
@MiguelCompany MiguelCompany deleted the feature/make_rtps_reader_impl_private branch May 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants