Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20989] Don't require Fast CDR v2 in examples #4833

Merged
merged 1 commit into from
May 23, 2024
Merged

[20989] Don't require Fast CDR v2 in examples #4833

merged 1 commit into from
May 23, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented May 23, 2024 •
edited by JesusPoderoso
Loading

Description

This PR removes the restriction of Fast CDR to be version 2 for examples, as they are prepared to also work with Fast CDR v1.

@Mergifyio backport 2.13.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
Refs #20989: Do not require Fast CDR v2 in examples
e1c5aba 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label May 23, 2024
@EduPonz EduPonz added this to the v2.14.2 milestone May 23, 2024
@EduPonz EduPonz marked this pull request as ready for review May 23, 2024 08:09
@EduPonz
Copy link
Author

EduPonz commented May 23, 2024

@Mergifyio backport 2.13.x

@mergify Mergify
Copy link
Contributor

mergify bot commented May 23, 2024 •
edited
Loading

backport 2.13.x

✅ Backports have been created

@EduPonz EduPonz requested a review from JesusPoderoso May 23, 2024 08:10
@github-actions github-actions bot added the ci-pending PR which CI is running label May 23, 2024
JesusPoderoso
JesusPoderoso approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 23, 2024
@JesusPoderoso JesusPoderoso merged commit fc576e4 into 2.14.x May 23, 2024
9 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/examples/dont_require_fastcdr2 branch May 23, 2024 09:46
mergify bot pushed a commit that referenced this pull request May 23, 2024
@EduPonz @mergify
Do not require Fast CDR v2 in examples (#4833)
c5bb225 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit fc576e4)
@mergify mergify bot mentioned this pull request May 23, 2024
Merged
8 tasks
EduPonz added a commit that referenced this pull request May 23, 2024
@mergify @EduPonz
Do not require Fast CDR v2 in examples (#4833) (#4834)
a904d84 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit fc576e4)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.2
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @JesusPoderoso