Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21168] Use token for ccache action #4931

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[21168] Use token for ccache action #4931

merged 1 commit into from
Jun 12, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jun 11, 2024 •
edited
Loading

Description

This PR uses a token for the setup-ccache action from in the CI, which is behind the CI failures on post steps due to exceeding github API usage rate limits

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A; The code follows the style guidelines of this project.
  • N/A; Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A; Any new/modified methods have been properly documented using Doxygen.
  • N/A; Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A; Changes are API compatible.
  • N/A; New feature has been added to the versions.md file (if applicable).
  • N/A; New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jun 11, 2024
@EduPonz EduPonz requested a review from JesusPoderoso June 11, 2024 09:45
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 11, 2024
JesusPoderoso
JesusPoderoso approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz
Refs #21168: Use token for ccache action
022177a 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/use_token_for_ci branch from 910b341 to 022177a Compare June 11, 2024 16:31
@EduPonz EduPonz requested a review from JesusPoderoso June 11, 2024 16:31
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 12, 2024
@EduPonz
Copy link
Author

EduPonz commented Jun 12, 2024

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 12, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

@EduPonz EduPonz merged commit 91d1432 into master Jun 12, 2024
10 of 11 checks passed
@EduPonz EduPonz deleted the feature/use_token_for_ci branch June 12, 2024 05:03
mergify bot pushed a commit that referenced this pull request Jun 12, 2024
@EduPonz @mergify
Use token for ccache action (#4931)
dbc5e7a 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 91d1432)
@mergify mergify bot mentioned this pull request Jun 12, 2024
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Jun 12, 2024
@EduPonz @mergify
Use token for ccache action (#4931)
83bf412 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 91d1432)
@mergify mergify bot mentioned this pull request Jun 12, 2024
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Jun 12, 2024
@EduPonz @mergify
Use token for ccache action (#4931)
5dd959a 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 91d1432)
mergify bot pushed a commit that referenced this pull request Jun 12, 2024
@EduPonz @mergify
Use token for ccache action (#4931)
173ad1d 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 91d1432)
This was referenced Jun 12, 2024
Merged
Closed
EduPonz added a commit that referenced this pull request Jun 12, 2024
@mergify @EduPonz
Use token for ccache action (#4931) (#4935)
6ff295d 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 91d1432)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Jun 12, 2024
@mergify @EduPonz
Use token for ccache action (#4931) (#4936)
5e9a831 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 91d1432)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Jun 13, 2024
@mergify @EduPonz
Use token for ccache action (#4931) (#4934)
4c4db19 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 91d1432)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso Awaiting requested review from JesusPoderoso

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @JesusPoderoso