Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only signed integers are permited in Dynamic Language Binding enumerations [21201] #4969

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 19, 2024

Description

TypeObject doesn't allow to contain the information whether a enumeration is signed or unsigned. It only stores the bit_bound. To avoid conflicts we were restricting the creation of enumerations using Dynamic Language Binding to only signed integers.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Only signed integers are permited in Dynamic Language Binding enumerations Only signed integers are permited in Dynamic Language Binding enumerations [21201] Jun 19, 2024
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2024
@EduPonz EduPonz added this to the v3.0.0 milestone Jun 21, 2024
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 21, 2024
@richiware richiware merged commit bdbfded into master Jun 21, 2024
15 of 17 checks passed
@richiware richiware deleted the feature/21199 branch June 21, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants