Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21244] Label flaky tests with xfail #5029

Merged
merged 5 commits into from
Jul 4, 2024
Merged

[21244] Label flaky tests with xfail #5029

merged 5 commits into from
Jul 4, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jul 3, 2024

Description

This PR marks several tests as flaky with the xfail label. The list of tests were taken from the 4/5 last runs on nighties, specially from Mac and Windows.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Mario-DL added 2 commits July 3, 2024 16:32
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v2.6.9 milestone Jul 3, 2024
@Mario-DL Mario-DL force-pushed the label-xfail-tests branch from 3703068 to 2c6f73b Compare July 3, 2024 14:37
@Mario-DL Mario-DL requested a review from richiprosima July 3, 2024 14:38
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 3, 2024
@Mario-DL Mario-DL changed the title Label xfail tests [21244] Label flaky tests with xfail Jul 3, 2024
@Mario-DL Mario-DL force-pushed the label-xfail-tests branch from 2c6f73b to bde39de Compare July 3, 2024 14:53
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima July 3, 2024 14:53
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL force-pushed the label-xfail-tests branch from bde39de to be0425d Compare July 3, 2024 14:54
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima July 3, 2024 14:54
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima July 3, 2024 18:54
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima July 4, 2024 06:19
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 4, 2024
@EduPonz EduPonz merged commit 5b39dcb into 2.6.x Jul 4, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the label-xfail-tests branch July 4, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants