Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DynamicType includes #5092

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add missing DynamicType includes #5092

merged 1 commit into from
Jul 22, 2024

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Jul 22, 2024

Description

This PR adds missing DynamicType header file in ITypeObjectRegistry.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Carlosespicur Carlosespicur requested a review from richiware July 22, 2024 05:54
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 22, 2024
@Carlosespicur Carlosespicur removed the request for review from richiware July 22, 2024 05:55
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the hotfix/include-dyntype branch from 69af8de to 747adcc Compare July 22, 2024 05:59
@Carlosespicur Carlosespicur requested a review from richiware July 22, 2024 05:59
@richiware richiware added the no-test Skip CI tests if PR marked with this label label Jul 22, 2024
@richiware richiware self-requested a review July 22, 2024 06:36
@richiware richiware added this to the v3.0.0 milestone Jul 22, 2024
@richiware richiware added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 22, 2024
@richiware richiware merged commit 26331c2 into master Jul 22, 2024
21 of 28 checks passed
@richiware richiware deleted the hotfix/include-dyntype branch July 22, 2024 09:03
@Carlosespicur Carlosespicur restored the hotfix/include-dyntype branch July 24, 2024 13:46
@rsanchez15 rsanchez15 deleted the hotfix/include-dyntype branch November 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants