Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21720] Modify help command of XML CLI tool #5246

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[21720] Modify help command of XML CLI tool #5246

merged 1 commit into from
Sep 20, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Sep 19, 2024 •
edited by JesusPoderoso
Loading

Description

The Fast DDS CLI tool does not properly display the validation argument in the help message.
This PR updates the help message to show proper argument.

@Mergifyio backport 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz
Refs #21720: Change command name
a840192 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v3.0.2 milestone Sep 19, 2024
@cferreiragonz cferreiragonz changed the title Modify help command of XML CLI tool [21720] Modify help command of XML CLI tool Sep 19, 2024
@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Sep 19, 2024
@JesusPoderoso JesusPoderoso self-requested a review September 19, 2024 13:43
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 19, 2024
JesusPoderoso
JesusPoderoso approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso
Copy link
Contributor

@Mergifyio backport 2.14.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport 2.14.x 2.10.x

✅ Backports have been created

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Sep 20, 2024
@richiware richiware merged commit 37cd84d into master Sep 20, 2024
14 checks passed
@richiware richiware deleted the feature/help_xml_tool branch September 20, 2024 06:45
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@cferreiragonz @mergify
Modify help command of XML CLI tool (#5246)
08ef0ed 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 37cd84d)
@mergify mergify bot mentioned this pull request Sep 20, 2024
Merged
10 tasks
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@cferreiragonz @mergify
Modify help command of XML CLI tool (#5246)
d6b25a9 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 37cd84d)
@mergify mergify bot mentioned this pull request Sep 20, 2024
Merged
10 tasks
MiguelCompany pushed a commit that referenced this pull request Sep 24, 2024
@mergify @cferreiragonz
Modify help command of XML CLI tool (#5246) (#5249)
b287e91 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 37cd84d)

Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Oct 28, 2024
@mergify @cferreiragonz
Modify help command of XML CLI tool (#5246) (#5250)
3691fe3 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 37cd84d)

Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@cferreiragonz @JesusPoderoso @richiware