Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21560] Bump to 2.14.4 #5441

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[21560] Bump to 2.14.4 #5441

merged 2 commits into from
Dec 2, 2024

Conversation

EugenioCollado
Copy link
Contributor

@EugenioCollado EugenioCollado commented Nov 28, 2024

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado EugenioCollado marked this pull request as ready for review November 28, 2024 11:08
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the thirdparty submodule of Fast CDR

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@cferreiragonz cferreiragonz self-requested a review November 29, 2024 10:51
@cferreiragonz cferreiragonz added the ci-pending PR which CI is running label Nov 29, 2024
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Member

The test failing on Windows seems unrelated, since it passes on v142.

@MiguelCompany MiguelCompany merged commit cbfb1e1 into 2.14.x Dec 2, 2024
17 of 18 checks passed
@MiguelCompany MiguelCompany deleted the release/v2.14.4 branch December 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants