Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21128] Adjust for Fast DDS public headers migration to .hpp #148

Merged
merged 4 commits into from
Jun 27, 2024
Merged

[21128] Adjust for Fast DDS public headers migration to .hpp #148

merged 4 commits into from
Jun 27, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 21, 2024 •
edited by EduPonz
Loading

Description

This PR is the counterpart of the following Fast DDS pull request in this repository:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Changes do not break current interoperability.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 21, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 21, 2024
@JesusPoderoso JesusPoderoso mentioned this pull request Jun 21, 2024
Merged
8 tasks
@JesusPoderoso
Refs #21128: Update headers from .h to .hpp
163fc1c 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21128: Update Shape types with Gen's PR
c453276 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21128: Update Keyless Shape types with Gen's PR
88186fd 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21128: Update PubSubTypes.hpp references
532c447 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso changed the title [21128] Make all public headers .hpp [21128] Adjust for Fast DDS public headers migration to .hpp Jun 26, 2024
EduPonz
EduPonz approved these changes Jun 26, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit 01e6bf0 into master Jun 27, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/21128 branch June 27, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @EduPonz