Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't escape slash with dynamic attributes #30

Merged
merged 1 commit into from
Nov 6, 2015

Conversation

k0kubun
Copy link
Contributor

@k0kubun k0kubun commented Nov 6, 2015

ref: #27

This PR fixes following inconsistent behavior.

$ cat in.haml
%a{ href: 'http://example.com' }
%a{ {}, href: 'http://example.com' }
$ bundle exec faml render in.haml
<a href='http://example.com'></a>
<a href='http:&#47;&#47;example.com'></a>

Since houdini_escape_html sets 1 as houdini_escape_html0's argument secure, it escapes "/".
I think Faml::AttributeBuilder should not escape "/". So I changed it to use houdini_escape_html0 and set secure argument to 0.

@eagletmt
Copy link
Owner

eagletmt commented Nov 6, 2015

eagletmt added a commit that referenced this pull request Nov 6, 2015
Don't escape slash with dynamic attributes
@eagletmt eagletmt merged commit 937c213 into eagletmt:master Nov 6, 2015
@k0kubun k0kubun deleted the dont-escape-slash branch November 6, 2015 13:35
@eagletmt
Copy link
Owner

eagletmt commented Nov 6, 2015

Released v0.3.6 💎

@k0kubun
Copy link
Contributor Author

k0kubun commented Nov 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants