Fix Issue #3: Read code signing entitlements from the application binary #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 8, 2018 17:22
Read the code signing entitlements directly from the application binary (using "codesign" application). Fallback to reading the provisioning profile if the binary has no entitlements set.
|
Looks great! I'm merging this in now, will test and push release to Cask later this week. Thanks! |
|
Thanks for merging, looking forward to the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement reading the code signing entitlements directly from the application binary,
instead of loading them from the provisioning profile.
This is useful because the provisioning profile will always have some entitlements set to wildcards, and will not reflect the actual entitlements being used by the app (eg.
keychain-access-groups).The application binary filename is read from the info.plist, extracted from the IPA (if necessary),
and the output from
codesign -d <AppBinary> --entitlements :-is saved.When replacing the entitlements section in the HTML, check if there are entitlements from the output of
codesignand use them.If there are none, fallback to the previous code, and read them from the provisioning profile.
Regarding the other commits: the bundle identifier defined in
Shared.hwas different from the one specified in theInfo.plist, causing the plugin to fail completely (Bundle was not found) and not render anything.I also updated the version to 1.3.1, because this version fixes a bug.