Go 1.15 changed the exit code for --help

golang/go#37533 I am Hyrum https://www.hyrumslaw.com
earthboundkid · Oct 2, 2020 · 3d9e153 · 3d9e153
1 parent 670ac0c
commit 3d9e153
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/code.go b/code.go
@@ -14,9 +14,8 @@ type Coder interface {
 
 // Get gets the exit code associated with an error. Cases:
 //
-//     nil => 0
+//     nil or flag.ErrHelp => 0
 //     errors implementing Coder => value returned by ExitCode
-//     flag.ErrHelp => 2
 //     all other errors => 1
 func Get(err error) int {
 	if err == nil {
@@ -28,7 +27,7 @@ func Get(err error) int {
 	}
 
 	if errors.Is(err, flag.ErrHelp) {
-		return 2
+		return 0
 	}
 
 	return 1

diff --git a/code_test.go b/code_test.go
@@ -19,7 +19,7 @@ func TestGet(t *testing.T) {
 	}{
 		"nil":     {nil, 0},
 		"default": {errors.New(""), 1},
-		"help":    {flag.ErrHelp, 2},
+		"help":    {flag.ErrHelp, 0},
 		"set":     {exitcode.Set(errors.New(""), 3), 3},
 		"wrapped": {wrapped, 4},
 	}