fix: linking existing customer to new Patient overwrites Customer Name (backport #306)

healthcare/healthcare/doctype/patient/patient.py

@@ -32,6 +32,7 @@ def onload(self):
 	def validate(self):
 		self.set_full_name()
 		self.flags.is_new_doc = self.is_new()
+		self.flags.existing_customer = self.is_new() and bool(self.customer)
 
 	def before_insert(self):
 		self.set_missing_customer_details()
@@ -46,18 +47,13 @@ def after_insert(self):
 	def on_update(self):
 		if frappe.db.get_single_value("Healthcare Settings", "link_customer_to_patient"):
 			if self.customer:
-				customer = frappe.get_doc("Customer", self.customer)
-				if self.customer_group:
-					customer.customer_group = self.customer_group
-				if self.territory:
-					customer.territory = self.territory
-				customer.customer_name = self.patient_name
-				customer.default_price_list = self.default_price_list
-				customer.default_currency = self.default_currency
-				customer.language = self.language
-				customer.image = self.image
-				customer.ignore_mandatory = True
-				customer.save(ignore_permissions=True)
+				if self.flags.existing_customer or frappe.db.exists(
+					{"doctype": "Patient", "name": ["!=", self.name], "customer": self.customer}
+				):
+					self.update_patient_based_on_existing_customer()
+				else:
+					self.update_linked_customer()
+
 			else:
 				create_customer(self)
 
@@ -253,6 +249,35 @@ def update_contact(self, contact):
 		contact.flags.skip_patient_update = True
 		contact.save(ignore_permissions=True)
 
+	def update_linked_customer(self):
+		customer = frappe.get_doc("Customer", self.customer)
+		if self.customer_group:
+			customer.customer_group = self.customer_group
+		if self.territory:
+			customer.territory = self.territory
+		customer.customer_name = self.patient_name
+		customer.default_price_list = self.default_price_list
+		customer.default_currency = self.default_currency
+		customer.language = self.language
+		customer.image = self.image
+		customer.ignore_mandatory = True
+		customer.save(ignore_permissions=True)
+
+		frappe.msgprint(_("Customer {0} updated").format(customer.name), alert=True)
+
+	def update_patient_based_on_existing_customer(self):
+		customer = frappe.get_doc("Customer", self.customer)
+		self.db_set(
+			{
+				"customer_group": customer.customer_group,
+				"territory": customer.territory,
+				"default_price_list": customer.default_price_list,
+				"default_currency": customer.default_currency,
+				"language": customer.language,
+			}
+		)
+		self.notify_update()
+
 
 def create_customer(doc):
 	customer = frappe.get_doc(
@@ -271,7 +296,7 @@ def create_customer(doc):
 	).insert(ignore_permissions=True, ignore_mandatory=True)
 
 	frappe.db.set_value("Patient", doc.name, "customer", customer.name)
-	frappe.msgprint(_("Customer {0} is created.").format(customer.name), alert=True)
+	frappe.msgprint(_("Customer {0} created and linked to Patient").format(customer.name), alert=True)
 
 
 def make_invoice(patient, company):

healthcare/healthcare/doctype/patient/test_patient.py

@@ -115,3 +115,19 @@ def test_patient_image_update_should_update_customer_image(self):
 
 		customer = frappe.get_doc("Customer", patient.customer)
 		self.assertEqual(customer.image, patient.image)
+
+	def test_multiple_paients_linked_with_same_customer(self):
+		frappe.db.sql("""delete from `tabPatient`""")
+		frappe.db.set_single_value("Healthcare Settings", "link_customer_to_patient", 1)
+
+		patient_name_1 = create_patient(patient_name="John Doe")
+		p1_customer_name = frappe.get_value("Patient", patient_name_1, "customer")
+		p1_customer = frappe.get_doc("Customer", p1_customer_name)
+		self.assertEqual(p1_customer.customer_name, "John Doe")
+
+		patient_name_2 = create_patient(patient_name="Jane Doe", customer=p1_customer.name)
+		p2_customer_name = frappe.get_value("Patient", patient_name_2, "customer")
+		p2_customer = frappe.get_doc("Customer", p2_customer_name)
+
+		self.assertEqual(p1_customer_name, p2_customer_name)
+		self.assertEqual(p2_customer.customer_name, "John Doe")