Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concepts that were needed to model new IAI apartment. #289

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

daniel86
Copy link
Member

@daniel86 daniel86 commented Nov 16, 2022

I only added a few concepts, including comments.
Some axioms will follow in another pull request.

Not sure though why there is so much refactoring ongoing. I edited with Protege 5.5.0

@daniel86 daniel86 requested a review from mpomarlan November 16, 2022 14:31
Declaration(Class(:WaterGlass))
Declaration(Class(:WineBottle))
Declaration(Class(:WineGlass))
Declaration(Class(<http://www.ease-crc.org/ont/SOMA-HOME.owl#Armchair>))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by the prefixes situation.

New concepts appear here with SOMA-HOME.owl in the prefix. At the same time, something like NutellaJar (seems too specific to be in SOMA proper) uses SOMA.owl as prefix. This is not an issue with this PR as such, rather it is something to keep in mind, perhaps by opening a github issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a related issue here: #288

@mpomarlan
Copy link
Collaborator

What's up with the SOMA Vocabulary step?

@daniel86
Copy link
Member Author

daniel86 commented Nov 17, 2022

What's up with the SOMA Vocabulary step?

to me it looks like the CI step cannot handle the new format. But I haven't looked deeper into it.

seems owl2ready is used: https://github.com/ease-crc/soma/blob/master/docs/vocab/owl_reader.py#L5

@daniel86 daniel86 closed this Nov 17, 2022
@daniel86 daniel86 reopened this Nov 17, 2022
@daniel86
Copy link
Member Author

What's up with the SOMA Vocabulary step?

to me it looks like the CI step cannot handle the new format. But I haven't looked deeper into it.

seems owl2ready is used: https://github.com/ease-crc/soma/blob/master/docs/vocab/owl_reader.py#L5

"Owlready2 currently reads the following file format: RDF/XML, OWL/XML, NTriples. The file format is automatically detected." they write here https://owlready2.readthedocs.io/en/latest/onto.html

@daniel86
Copy link
Member Author

daniel86 commented Nov 17, 2022

What's up with the SOMA Vocabulary step?

yeah it looks like owl2ready cannot handle functional syntax, which is the format of the file passed to it here: https://github.com/ease-crc/soma/blob/master/docs/vocab/SOMA-vocabulary.tex#L21
However, it looks like the wrong file is passed, i.e., not the bundled version. So I guess a fix would be to instead supply the bundled version in XML format to owl2ready.

here is a ticket about it: #290

@daniel86 daniel86 merged commit 4859b22 into master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants