Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should fix_python_shebang_for="bin/*" be default in PythonPackage? #3498

Closed
VRehnberg opened this issue Nov 1, 2024 · 3 comments
Closed

Should fix_python_shebang_for="bin/*" be default in PythonPackage? #3498

VRehnberg opened this issue Nov 1, 2024 · 3 comments
Labels
change request EasyBuild-5.0 EasyBuild 5.0
Milestone
5.0

Comments

@VRehnberg
Copy link
Contributor

Pip installed python scripts will (as far as I can tell) replace the shebang with a hardcoded path to the Python used in the installation.

This means that virtualenv --system-site-packages won't be picked up.

The easy fix for these are to add:

fix_python_shebang_for = ['bin/*']

in the easyconfig.

But, looking at what we had installed on our cluster this is not done for a lot of softwares.

I suggest that either:

  • add this as default
  • have a sanity check to catch when this hasn't been added but should've
@boegel boegel added this to the 4.x milestone Nov 6, 2024
@boegel boegel changed the title Should fix_python_shebang_for="bin/*" be default in PythonPackage? Should fix_python_shebang_for="bin/*" be default in PythonPackage? Nov 6, 2024
@boegel
Copy link
Member

boegel commented Nov 6, 2024

I think it makes sense to use this as default, especially since we're quite careful to not make change when there's no need for it (see also easybuilders/easybuild-framework#4209 + easybuilders/easybuild-framework#3208).

@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Nov 6, 2024
@boegel boegel modified the milestones: 4.x, 5.0 Nov 6, 2024
VRehnberg added a commit to VRehnberg/easybuild-easyblocks that referenced this issue Nov 6, 2024
@VRehnberg
Pythonpkg fix_python_shebang_for default ['bin/*']
86946e8 
Make fix_python_shebang_for = ['bin/*'] default in PythonPackage
easyblock. As discussed in:
easybuilders#3498
@VRehnberg VRehnberg mentioned this issue Nov 6, 2024
Merged
@VRehnberg
Copy link
Contributor Author

Created a PR #3499

@boegel
Copy link
Member

boegel commented Dec 4, 2024

fixed with #3499

@boegel boegel closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change request EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@boegel @VRehnberg