Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add easyblock for ELSI #1883

Merged
merged 7 commits into from
Feb 14, 2020
Merged

Conversation

migueldiascosta
Copy link
Member

there are more libraries besides ELPA that can be specified as external instead of built, and other optional libraries, see "Solver Libraries and External Dependencies" in https://wordpress.elsi-interchange.org/index.php/download/, not sure if there is demand for those

Motivation was its use in the new "MaX release version" of SIESTA (PR coming soon)

boegel
boegel previously requested changes Dec 13, 2019
easybuild/easyblocks/e/elsi.py Outdated Show resolved Hide resolved
easybuild/easyblocks/e/elsi.py Outdated Show resolved Hide resolved
easybuild/easyblocks/e/elsi.py Outdated Show resolved Hide resolved
@boegel boegel added this to the 4.x milestone Dec 13, 2019
easybuild/easyblocks/e/elsi.py Outdated Show resolved Hide resolved
easybuild/easyblocks/e/elsi.py Outdated Show resolved Hide resolved
easybuild/easyblocks/e/elsi.py Outdated Show resolved Hide resolved
easybuild/easyblocks/e/elsi.py Outdated Show resolved Hide resolved
easybuild/easyblocks/e/elsi.py Outdated Show resolved Hide resolved
akesandgren
akesandgren previously approved these changes Feb 14, 2020
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migueldiascosta migueldiascosta changed the title add easyblock for ELSI (WIP) add easyblock for ELSI Feb 14, 2020
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren dismissed boegel’s stale review February 14, 2020 11:43

Code changed in a different way.

@akesandgren
Copy link
Contributor

Going in, thanks @migueldiascosta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants