add EPYC to KOKKOS_CPU_ARCH_LIST and MAPPING in LAMMPS easyblock #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 26, 2020
|
for the current version of LAMMPS in easybuilders/easybuild-easyconfigs#9883 and easybuilders/easybuild-easyconfigs#9884, this also requires an easyconfig patch with * EPYC is supported in kokkos, but is missing from this arch list
--- lammps-stable_7Aug2019/lib/kokkos/cmake/kokkos_options.cmake.orig 2020-02-26 10:22:02.335120843 +0800
+++ lammps-stable_7Aug2019/lib/kokkos/cmake/kokkos_options.cmake 2020-02-26 10:22:53.470621040 +0800
@@ -78,6 +78,7 @@
list(APPEND KOKKOS_ARCH_LIST
None # No architecture optimization
AMDAVX # (HOST) AMD chip
+ EPYC # (HOST) AMD EPYC Zen-Core CPU
ARMv80 # (HOST) ARMv8.0 Compatible CPU
ARMv81 # (HOST) ARMv8.1 Compatible CPU
ARMv8-ThunderX # (HOST) ARMv8 Cavium ThunderX CPU |
|
@migueldiascosta Is it worth the trouble to open a pull request to https://github.com/lammps/lammps to add |
4 tasks
…asyblocks into 20200226111850_new_pr_ksZRnoQRDe
|
verified that the LAMMPS version in easybuilders/easybuild-easyconfigs#10191 no longer requires the patch above in order to build on EPYC, only this PR |
|
Going in, thanks @migueldiascosta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)