Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added regex to replace /lib/cpp with cpp in OpenFOAM's wmake rules file #2331

Merged
merged 1 commit into from
Feb 14, 2022
Merged

added regex to replace /lib/cpp with cpp in OpenFOAM's wmake rules file #2331

merged 1 commit into from
Feb 14, 2022

Conversation

mboisson
Copy link
Contributor

@boegel boegel changed the title added regex to replace /lib/cpp with cpp added regex to replace /lib/cpp with cpp in OpenFOAM's wmake rules file Feb 17, 2021
@boegel boegel added the bug fix label Feb 17, 2021
@boegel boegel added this to the release after 4.3.3 milestone Feb 17, 2021
@boegel boegel modified the milestones: 4.4.0, release after 4.4.0 May 26, 2021
@boegel boegel modified the milestones: 4.4.2, release after 4.4.2 Sep 1, 2021
@boegel boegel modified the milestones: 4.5.1, release after 4.5.1 Dec 7, 2021
@boegel boegel modified the milestones: 4.5.2, release after 4.5.2 Jan 14, 2022
@boegel boegel modified the milestones: 4.5.3, release after 4.5.3 Feb 9, 2022
akesandgren
akesandgren approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @mboisson!

@akesandgren akesandgren merged commit 957b6ba into easybuilders:develop Feb 14, 2022
@boegel
Copy link
Member

boegel commented Feb 17, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-9-foss-2021a.eb
  • SUCCESS OpenFOAM-v2112-foss-2021b.eb
  • SUCCESS OpenFOAM-6-foss-2019b.eb
  • SUCCESS OpenFOAM-v1906-foss-2019b.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3561.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/152642aaa22825d5adee09cf07d9d11e for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mboisson @akesandgren @boegel