Make sure OpenFOAM sanity checks don't require builddir write permissions #2415
Conversation
| @@ -489,9 +490,10 @@ def sanity_check_step(self): | |||
| openfoamdir_path = os.path.join(self.installdir, self.openfoamdir) | |||
| motorbike_path = os.path.join(openfoamdir_path, 'tutorials', 'incompressible', 'simpleFoam', 'motorBike') | |||
| if os.path.exists(motorbike_path): | |||
| test_dir = tempfile.mkdtemp() | |||
There was a problem hiding this comment.
This may cause issues if the example is run on more than one node
There was a problem hiding this comment.
but it is fixable by setting the --tmpdir option to be on a parallel file system
There was a problem hiding this comment.
I think it's safe to assume that in general EasyBuild isn't running in a multi-node context...
|
Can we get generoso to make a test report for this ? Can't remember if that's easy to do? |
|
@akesandgren Not easily currently, the bot only listens to requests in the easyconfigs repo. I kicked off a couple of |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Going in, thanks @ocaisa! |
boegel
changed the title
Fixes #2400