Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept both None and empty value for optarch to let OpenCV detect host CPU #2804

Merged
merged 1 commit into from
Oct 17, 2022
Merged

accept both None and empty value for optarch to let OpenCV detect host CPU #2804

merged 1 commit into from
Oct 17, 2022

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Oct 17, 2022 •
edited
Loading

(created using eb --new-pr)
this allows to remove the default optarch setting, for example in jsc-zen2 boegelbot

@smoors smoors mentioned this pull request Oct 17, 2022
Merged
1 task
@casparvl
Copy link
Contributor

casparvl commented Oct 17, 2022 •
edited
Loading

I'll try to upload a test report for easybuilders/easybuild-easyconfigs#16393 on my local systems with this EasyBlock, and passing optarch=''. (note: the test report will probably end up in the EasyConfigs PR)

@casparvl
Copy link
Contributor

So far so good, I get -DCPU_BASELINE=DETECT in the configure step, as expected :)

@casparvl casparvl mentioned this pull request Oct 17, 2022
Merged
@casparvl
Copy link
Contributor

Succesful tests in easybuilders/easybuild-easyconfigs#16392 (comment) , easybuilders/easybuild-easyconfigs#16393 (comment) and easybuilders/easybuild-easyconfigs#16393 (comment)

casparvl
casparvl approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl added this to the next release (4.6.2?) milestone Oct 17, 2022
@casparvl casparvl merged commit 2493cbd into easybuilders:develop Oct 17, 2022
@boegel boegel changed the title allow empty optarch string for opencv accept both None and empty value for optarch to let OpenCV detect host CPU Oct 19, 2022
@smoors smoors mentioned this pull request Mar 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casparvl casparvl casparvl approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@smoors @casparvl @boegel