-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make PythonPackage easyblock compatible with --sanity-check-only by loading module early during sanity check step #2828
make PythonPackage easyblock compatible with --sanity-check-only by loading module early during sanity check step #2828
Conversation
…_check_load_module (fixes easybuilders#2745)
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 5 (5 easyconfigs in total) |
Hmm, clearly not working yet as intended... |
…ince module is already loaded at start of PythonPackage.sanity_check_step
A fix in |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @boegel! |
requires:
fixes #2745