Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make PythonPackage easyblock compatible with --sanity-check-only by loading module early during sanity check step #2828

Conversation

@boegel boegel added the bug fix label Nov 16, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Nov 16, 2022
@boegel
Copy link
Member Author

boegel commented Nov 16, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 5 (5 easyconfigs in total)
node3139.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/8a8fb30fb0352c57ebca18d86bb9ffd2 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 16, 2022

Hmm, clearly not working yet as intended...

…ince module is already loaded at start of PythonPackage.sanity_check_step
@boegel
Copy link
Member Author

boegel commented Nov 24, 2022

A fix in extensioneasyblock.py was also needed (see easybuilders/easybuild-framework@e282dbe), as well as not generating/loading the fake module prior to running pip check in PythonPackage.sanity_check_step (see 57288b6).

@boegel boegel requested a review from ocaisa November 24, 2022 21:36
@boegel
Copy link
Member Author

boegel commented Nov 24, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Python-3.9.6-GCCcore-11.2.0.eb
  • SUCCESS xarray-0.15.1-foss-2019b-Python-3.7.4.eb
  • SUCCESS scikit-learn-0.24.2-intel-2021a.eb
  • SUCCESS matplotlib-3.5.2-foss-2022a.eb
  • SUCCESS h5py-3.6.0-intel-2021b.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3102.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/2c71f107ee6f26b04160539cc417b1ea for a full test report.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 8c89bcb into easybuilders:develop Dec 8, 2022
@boegel boegel deleted the pythonpackage_sanity_check_load_module branch December 8, 2022 08:55
@boegel boegel changed the title load module early during PythonPackage's sanity check step via sanity_check_load_module make PythonPackage easyblock compatible with --sanity-check-only by loading module early during sanity check step Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PythonPackage is not compatible with --sanity-check-only
2 participants