Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set $TEMPDIRPATH for testsuite in the BerkeleyGW easyblock, to avoid polluting /tmp #2836

Merged
merged 1 commit into from
Dec 27, 2022
Merged

set $TEMPDIRPATH for testsuite in the BerkeleyGW easyblock, to avoid polluting /tmp #2836

merged 1 commit into from
Dec 27, 2022

Conversation

migueldiascosta
Copy link
Member

(created using eb --new-pr)

@migueldiascosta migueldiascosta added this to the next release (4.7.0) milestone Nov 29, 2022
@boegelbot boegelbot mentioned this pull request Nov 29, 2022
Closed
@boegel boegel changed the title set TEMPDIRPATH for testsuite in the BerkeleyGW easyblock, to avoid polluting /tmp set $TEMPDIRPATH for testsuite in the BerkeleyGW easyblock, to avoid polluting /tmp Dec 6, 2022
@migueldiascosta
Copy link
Member Author

this shouldn't be a blocker for 4.7.0, but it's also trivial, do we need to test all the existing easyconfigs with it?

@boegel
Copy link
Member

boegel commented Dec 27, 2022

this shouldn't be a blocker for 4.7.0, but it's also trivial, do we need to test all the existing easyconfigs with it?

Not a blocker indeed, but some test report here would be nice (I just started the process for submitting one)

@boegel
Copy link
Member

boegel commented Dec 27, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS BerkeleyGW-2.1.0-foss-2019b-Python-3.7.4.eb
  • SUCCESS BerkeleyGW-2.1.0-intel-2019b-Python-3.7.4.eb
  • SUCCESS BerkeleyGW-3.0.1-foss-2020b.eb
  • SUCCESS BerkeleyGW-3.0.1-foss-2021a.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3101.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/ef3e3d1dc3e00a4e6dd8187d9f296ba9 for a full test report.

boegel
boegel approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 4d36e56 into easybuilders:develop Dec 27, 2022
This was referenced Jan 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@migueldiascosta @boegel