Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fixed names for bazel/wrapper subdirectories used when building TensorFlow, to make debugging easier #2841

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Dec 2, 2022

(created using eb --new-pr)

We don't need random temporary folders for the output-user-root folder Bazel and the binary wrappers (if any) so we can use a fixed folder name.

This makes it easier to rebuild TF manually using the same command and reusing the current state of the (Bazel) build files.

@branfosj branfosj added this to the next release (4.7.0) milestone Dec 4, 2022
@branfosj
Copy link
Member

branfosj commented Dec 4, 2022

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.6.0-foss-2021a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.5, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/aac7ad86be111a52909e6bd31cac58b1 for a full test report.

@branfosj
Copy link
Member

branfosj commented Dec 4, 2022

Going in, thanks @Flamefire!

@branfosj branfosj merged commit 99ee865 into easybuilders:develop Dec 4, 2022
@Flamefire Flamefire deleted the 20221202124223_new_pr_tensorflow branch December 4, 2022 12:44
@boegel boegel changed the title Make TensorFlow builds easier to debug use fixed names for bazel/wrapper subdirectories used when building TensorFlow, to make debugging easier Dec 6, 2022
@boegel boegel added change and removed enhancement labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants