add options to MesonNinja easyblock to customize build_cmd, install_cmd, builddir
#2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
MesonNinja easyblock to customize build_cmd, install_cmd, builddir
boegel
requested changes
Aug 2, 2023
boegel
changed the title
MesonNinja easyblock to customize build_cmd, install_cmd, builddirMesonNinja easyblock to customize build_cmd, install_cmd, builddir
boegel
requested changes
Aug 30, 2023
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 7 (4 easyconfigs in total) |
Flamefire
reviewed
Sep 4, 2023
| @@ -49,7 +51,10 @@ def extra_options(extra_vars=None): | |||
| """Define extra easyconfig parameters specific to MesonNinja.""" | |||
| extra_vars = EasyBlock.extra_options(extra_vars) | |||
| extra_vars.update({ | |||
| 'build_dir': [None, "build_dir to pass to meson", CUSTOM], | |||
| 'build_cmd': [DEFAULT_BUILD_CMD, "Build command to use", CUSTOM], | |||
There was a problem hiding this comment.
This breaks the CMakeNinja EasyBlock which doesn't call this method and hence has "make" as the build_cmd
-> #2993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a MesonNinja EasyConfig (SU2) that comes bundled with its own meson, but also its own ninja. I need to be able to override the
ninjacommand to use the./ninjacommand from the source directory. It also needs to build in a specific folder (build), so I need to be able to override thebuilddir(which is mislabelled assourcedirin the EasyBlock) that is passed to the Meson configure command.