-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new easyblock for DualSPHysics #3050
Merged
akesandgren
merged 6 commits into
easybuilders:develop
from
jfgrimm:20231212112825_new_pr_dualsphysics
Jan 8, 2024
Merged
new easyblock for DualSPHysics #3050
akesandgren
merged 6 commits into
easybuilders:develop
from
jfgrimm:20231212112825_new_pr_dualsphysics
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jfgrimm
changed the title
new easyblock for dualsphysics
new easyblock for DualSPHysics
Dec 12, 2023
akesandgren
reviewed
Jan 4, 2024
jfgrimm
commented
Jan 4, 2024
successful report: |
akesandgren
requested changes
Jan 5, 2024
Tested version of DualSPHysics-5.0.175-GCC-11.2.0.eb before using this easyblock (which fails) and the version from easybuilders/easybuild-easyconfigs#19400 (which works) |
akesandgren
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @jfgrimm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with EasyBuild configured to use rpath, the sanity checks for the existing easyconfig fail because some prebuilt binaries and libraries are bundled in the tarball, and these don't have an RPATH section. The new easyblock runs
patchelf
to add a corresponding entry.corresponding easyconfigs PR: easybuilders/easybuild-easyconfigs#19400
(created using
eb --new-pr
)