Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely mention that the PyTorch easyblock needs updating when failing for this reason #3255

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Mar 13, 2024

(created using eb --new-pr)

See easybuilders/easybuild-easyconfigs#19666 (comment) for the motivation

@Flamefire
Copy link
Contributor Author

@casparvl I updated the EasyBlock after the discussion at #3255 (comment)

I also noticed and fixed 2 things:

  • If we can't count failures we only failed if we counted ANY failure
  • We can't count failures if a test aborted but the previous iteration showed a message that the EasyBlock needed updating

I moved the detection of "uncounted suites" into the parser function such that we can test it (manually).

@Flamefire Flamefire force-pushed the 20240313110424_new_pr_pytorch branch from cae8f4e to 20b60c3 Compare August 8, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants