Set build type for PyTorch explicitely #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyTorch checks these environment variables in this order to determine the build type (for CMake) to use: - CMAKE_BUILD_TYPE - DEBUG - REL_WITH_DEB_INFO If we don't set it explicitely we might end up with an unexpected debug build. Add the `build_type`EC option used in the CMakeMake easyblock with similar semantics.
Co-authored-by: SebastianAchilles <s.achilles@fz-juelich.de>
|
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
|
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch checks these environment variables in this order to determine the build type (for CMake) to use:
If we don't set it explicitely we might end up with an unexpected debug build.
Add the
build_typeEC option used in the CMakeMake easyblock with similar semantics.