stick to flake8 7.0.0 for linting easyblocks (for now)
#3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only for develop to avoid having to fix `geant4.py` (see https://github.com/easybuilders/easybuild-easyblocks/actions/runs/9552967707/job/26330689071?pr=3364)
1 task
boegel
reviewed
Jun 18, 2024
| @@ -22,7 +22,8 @@ jobs: | |||
| - name: install Python packages | |||
| run: | | |||
| pip install --upgrade pip | |||
| pip install --upgrade flake8 | |||
| # fix to this version for develop branch (to avoid needing to fix geant4.py) | |||
| pip install --upgrade "flake8<7.1" | |||
There was a problem hiding this comment.
We'll sync develop to 5.0.x eventually, so this will also land in there (unless we kick it out when doing sync), but OK for now...
boegel
approved these changes
Jun 18, 2024
boegel
changed the title
flake8 7.0.0 for linting easyblocksflake8 7.0.0 for linting easyblocks (for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only for
developto avoid having to fixgeant4.py(see https://github.com/easybuilders/easybuild-easyblocks/actions/runs/9552967707/job/26330689071?pr=3364).Not needed in
5.0.xas we've removed that section of the easyblock.