Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace run_cmd with run_shell_cmd in custom easyblock for QuantumESPRESSO #3411

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Crivella
Copy link
Contributor

@boegel
Copy link
Member

boegel commented Aug 14, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="QuantumESPRESSO-6.8-foss-2021b.eb QuantumESPRESSO-7.3.1-foss-2023a.eb QuantumESPRESSO-7.2-intel-2022b.eb"
EB_BRANCH=5.0.x

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3411 EB_ARGS="QuantumESPRESSO-6.8-foss-2021b.eb QuantumESPRESSO-7.3.1-foss-2023a.eb QuantumESPRESSO-7.2-intel-2022b.eb" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3411 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4686

Test results coming soon (I hope)...

- notification for comment with ID 2289685124 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Aug 15, 2024

Requested test builds never started because QuantumESPRESSO-7.3.1-foss-2023a.eb is not available yet in 5.0.x branch since it hasn't been synced with develop recently, fixing that in #21191

@boegel
Copy link
Member

boegel commented Aug 15, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="QuantumESPRESSO-6.8-foss-2021b.eb QuantumESPRESSO-7.3.1-foss-2023a.eb QuantumESPRESSO-7.2-intel-2022b.eb"
EB_BRANCH=5.0.x

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3411 EB_ARGS="QuantumESPRESSO-6.8-foss-2021b.eb QuantumESPRESSO-7.3.1-foss-2023a.eb QuantumESPRESSO-7.2-intel-2022b.eb" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3411 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4691

Test results coming soon (I hope)...

- notification for comment with ID 2292341058 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS QuantumESPRESSO-6.8-foss-2021b.eb
  • SUCCESS QuantumESPRESSO-7.3.1-foss-2023a.eb
  • SUCCESS QuantumESPRESSO-7.2-intel-2022b.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/48f8d56cc463ab6b520f44d69a0aeaef for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 2fff133 into easybuilders:5.0.x Aug 16, 2024
19 checks passed
@Crivella Crivella deleted the feature-qe_new-run_shell_cmd branch August 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants