Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance NAMD easyblock to support NAMD v3.0 #3494

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

maxim-masterov
Copy link
Contributor

@maxim-masterov maxim-masterov commented Oct 23, 2024

NAMD-3.0 depends on charm-8.0.0 that uses Automake. The 'configure' file was removed in favour of 'configure.ac'.

ppomorsk added a commit to ComputeCanada/easybuild-easyblocks that referenced this pull request Oct 31, 2024
Add support for charm-8.0.0 bundled with NAMD 3 - code from easybuilders#3494
bartoldeman pushed a commit to ComputeCanada/easybuild-easyblocks that referenced this pull request Oct 31, 2024
Add support for charm-8.0.0 bundled with NAMD 3 - code from easybuilders#3494
@boegel boegel added the update label Nov 6, 2024
@boegel boegel added this to the release after 4.9.4 milestone Nov 6, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Nov 6, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="NAMD-2.14-foss-2022a-mpi.eb NAMD-2.14-foss-2023a-mpi.eb"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3494 EB_ARGS="NAMD-2.14-foss-2022a-mpi.eb NAMD-2.14-foss-2023a-mpi.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3494 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5196

Test results coming soon (I hope)...

- notification for comment with ID 2459004684 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS NAMD-2.14-foss-2022a-mpi.eb
  • SUCCESS NAMD-2.14-foss-2023a-mpi.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/8e439673e04b5aa8e97abf99c02f5821 for a full test report.

@boegel boegel merged commit 5092c2d into easybuilders:develop Nov 6, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants