Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain custom easyconfig parameters supported by MesonNinja easyblock in custom easyblock for scipy #3526

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Dec 11, 2024

I modified it to a pattern that i saw used in other easyblocks (like MesonNinja.extra_options) to make it more consistent.

fixes #3524

@Micket Micket added the bug fix label Dec 11, 2024
@Micket Micket added this to the 5.0 milestone Dec 11, 2024
@Micket
Copy link
Contributor Author

Micket commented Dec 11, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2024.05-gfbf-2024a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/7581ec94c513af8be3ec604c37c8afe4 for a full test report.

@boegel boegel changed the title Include meson ninja extra options to scipy retain custom easyconfig parameters supported by MesonNinja easyblock in custom easyblock for scipy Dec 11, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Dec 11, 2024

Verified with:

$ eb -a -e EB_scipy |grep build_type
build_type*               Build type for meson, e.g. release.Replaces use of toolchain options debug, noopt, lowopt, opt [default: None]

@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Dec 11, 2024
@boegel boegel merged commit 3494f2f into easybuilders:5.0.x Dec 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants