Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove FFTW dependencies from LAMMPS easyconfigs, no longer needed (MKL can be used too now) #10565

Merged
merged 1 commit into from
May 6, 2020
Merged

remove FFTW dependencies from LAMMPS easyconfigs, no longer needed (MKL can be used too now) #10565

merged 1 commit into from
May 6, 2020

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented May 4, 2020

since easybuilders/easybuild-easyblocks#1997, and since these are part of the toolchain they should not be included as dep.

@ocaisa ocaisa changed the title easyblock can now detect FFTW or MKL LAMMPS easyblock can now detect FFTW or MKL May 4, 2020
@ocaisa ocaisa mentioned this pull request May 4, 2020
Closed
@ocaisa
Copy link
Member Author

ocaisa commented May 4, 2020

Test report by @ocaisa
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/bf53071e4acee05f1cf85fc6b1bda0e3 for a full test report.

@boegel boegel changed the title LAMMPS easyblock can now detect FFTW or MKL remove FFTW dependencies from LAMMPS easyconfigs, no longer needed (MKL can be used too now) May 6, 2020
@boegel boegel added this to the next release (4.2.1?) milestone May 6, 2020
boegel
boegel approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test reports coming up

@boegel
Copy link
Member

boegel commented May 6, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node3125.skitty.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/c244c1b17771d91c6db46a4b0b3acfba for a full test report.

@boegel
Copy link
Member

boegel commented May 6, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2658.swalot.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/e76622b273d50009cb28a14a0bceb119 for a full test report.

@boegel
Copy link
Member

boegel commented May 6, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso-1 - Linux centos linux 7.6.1810, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/6b8e9533a7233785a8b225c62ac30840 for a full test report.

@boegel
Copy link
Member

boegel commented May 6, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node3401.kirlia.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/6d7b2e65d68bafd59af6f73f3ba00f75 for a full test report.

@boegel
Copy link
Member

boegel commented May 6, 2020

Going in, thanks @ocaisa!

@boegel boegel merged commit 10d6169 into easybuilders:develop May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix change
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ocaisa @boegel