Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Mako easyconfigs using a 2016 & 2017 toolchain #10627

Merged
merged 3 commits into from
May 13, 2020
Merged

fix Mako easyconfigs using a 2016 & 2017 toolchain #10627

merged 3 commits into from
May 13, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented May 12, 2020

fixes #10462

@boegel boegel added the bug fix label May 12, 2020
@boegel boegel added this to the next release (4.2.1?) milestone May 12, 2020
@easybuilders easybuilders deleted a comment from boegelbot May 12, 2020
@boegel
Copy link
Member Author

boegel commented May 13, 2020

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/312efd016564abff56da5c39dfe96978 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 13, 2020

close/re-open to wake up Travis...

@boegel boegel closed this May 13, 2020
@boegel boegel reopened this May 13, 2020
@boegel
Copy link
Member Author

boegel commented May 13, 2020

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node2618.swalot.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/1f7061212129c31ac43bf8ef2674ea0b for a full test report.

verdurin
verdurin approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

Going in, thanks @boegel!

@verdurin verdurin merged commit 2f884aa into easybuilders:develop May 13, 2020
@boegel boegel deleted the fix_Mako_2016_2017 branch May 14, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verdurin verdurin verdurin approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

installation of older Mako easyconfigs broken because MarkupSafe 2.0.0a1 is picked up
2 participants
@boegel @verdurin