Require sanity_pip_check for all Python package/bundles #12464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
|
going in, thanks @Flamefire !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #12456 (comment)
IMO it should always be required as this could/does(?) catch the recent issue where installation via setup.py resulted in a version of 0.0.0
@boegel
pipalso sees packages installed bysetup.pyand that might introduce conflicts as well which would make later installations that use this software fail.It may catch the 0.0.0 versions indirectly: When another package requires a specific version of this software but that is 0.0.0
pip checkwill failA proper check is in easybuilders/easybuild-easyblocks#2367