Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't skip source step in FastTree easyconfigs + fix SHA256 checksum for FastTree 2.1.11 #12794

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented May 1, 2021

(created using eb --new-pr)

This faulty checksum went undetected because these easyconfigs use skipsteps = ['source'], so the checksums never get validated... 🤦

@boegel boegel added the bug fix label May 1, 2021
@boegel boegel added this to the next release (4.3.5?) milestone May 1, 2021
@boegel
Copy link
Member Author

boegel commented May 1, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12794 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12794 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16963

Test results coming soon (I hope)...

- notification for comment with ID 830575781 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4b4b9017912725762a4ce56ce45e4b10 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 1, 2021

We should probably introduce a big fat warning when skipsteps = ['source'] is used, or perhaps disallow it, and definitely avoid using it in easyconfigs in the central repo...

@branfosj
Copy link
Member

branfosj commented May 1, 2021

To have the checksums are validated:

  • sources = [{'filename': '%(name)s-%(version)s.c', 'extract_cmd': 'cp %s FastTree.c'}]
  • Remove skipsteps = ['source']
  • cmds_map = [('%(name)s-%(version)s.c', '$CC -DOPENMP $CFLAGS $LIBS %(name)s.c -o %(name)s')]

@boegel boegel changed the title fix SHA256 checksum for FastTree 2.1.11 don't skip source step in FastTree easyconfigs + fix SHA256 checksum for FastTree 2.1.11 May 4, 2021
@boegel
Copy link
Member Author

boegel commented May 4, 2021

@boegelbot please test @ generoso
EB_ARGS="FastTree-2.1.10-foss-2018b.eb FastTree-2.1.11-GCCcore-8.2.0.eb FastTree-2.1.11-GCCcore-8.3.0.eb FastTree-2.1.11-GCCcore-9.3.0.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12794 EB_ARGS="FastTree-2.1.10-foss-2018b.eb FastTree-2.1.11-GCCcore-8.2.0.eb FastTree-2.1.11-GCCcore-8.3.0.eb FastTree-2.1.11-GCCcore-9.3.0.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_12794 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16996

Test results coming soon (I hope)...

- notification for comment with ID 831741689 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b4145ad675189e8ac933ae8655878368 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 4, 2021

@boegelbot please test @ generoso
EB_ARGS="FastTree-2.1.10-foss-2018b.eb FastTree-2.1.11-GCCcore-8.2.0.eb FastTree-2.1.11-GCCcore-8.3.0.eb FastTree-2.1.11-GCCcore-9.3.0.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12794 EB_ARGS="FastTree-2.1.10-foss-2018b.eb FastTree-2.1.11-GCCcore-8.2.0.eb FastTree-2.1.11-GCCcore-8.3.0.eb FastTree-2.1.11-GCCcore-9.3.0.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_12794 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16999

Test results coming soon (I hope)...

- notification for comment with ID 831755428 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/9adc6ef520c76f7dca240c3624e87bde for a full test report.

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

branfosj commented May 4, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit 625527b into easybuilders:develop May 4, 2021
@boegel boegel deleted the 20210501094201_new_pr_FastTree2111 branch May 4, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants