-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patch for BLIS to fix auto-detection of POWER #15826
add patch for BLIS to fix auto-detection of POWER #15826
Conversation
Test report by @jfgrimm |
This comment was marked as outdated.
This comment was marked as outdated.
f61ed6a
to
8a0c694
Compare
8a0c694
to
5e50cd1
Compare
Test report by @jfgrimm |
Test report by @Flamefire |
Test report by @Flamefire |
@boegelbot please test @ jsc-zen2 |
@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1178221339 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@jfgrimm sorry for the failures, seemingly the versions are not really incremental so some patches I thought would still apply didn't. As can be seen by recent test reports this is now fixed. |
@boegelbot please test @ generoso |
@jfgrimm: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1178658211 processed Message to humans: this is just bookkeeping information for me, |
I'm still seeing test failures on my machine:
although I think that's unrelated to the changes in this PR, so shouldn't block this |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @Flamefire! |
Seems like I introduced a bug here for 2.2 and 3.0: They don't support POWER10 so the code doesn't compile on any PPC. Fix included in #15889 This still doesn't fully solve the BLIS build on PPC due to segfaults in 0.9.0 (flame/blis#621) and timeouts during tests in 3.0.1 |
(created using
eb --new-pr
)