-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add and fix patches for PyTorch 1.9.0 on POWER #15919
add and fix patches for PyTorch 1.9.0 on POWER #15919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Build now works although 2 tests fail on PPC:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (mainly because i don't know any better) (I'll try to find a machine to run build report from)
Oops, missed that it was marked draft! |
Done now. Just noticed a mistake and wanted to wait for the custom test first. Started a job testing this on PPC now. |
Test report by @Flamefire |
Test report by @Flamefire |
Ok, this works now, the failing EC is PyTorch-1.9.0-fosscuda-2020b-imkl.eb as IMKL isn't available for PPC, so that is ok. |
Test report by @Flamefire |
One failing test for
|
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't let the failing test_autograd
test block this PR, since it also occurs without the changes in this PR.
@Flamefire Is this something worth following up on?
Going in, thanks @Flamefire! |
Yes, looks worth to double check at least: #16233 |
Test report by @Flamefire |
(created using
eb --new-pr
)The patch introduced a C&P bug resulting in:
I.e.
b
was used instead ofexp
.Although in the referenced PR I left that function untouched it seems to be required as without it the
test_binary_ufuncs
fails but succeeds with it.Added a commit to make the change correct.