Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libffi and elfutils as dependency for Clang v11.0.1 + v12.0.1 #15935

Merged

Conversation

bowentan
Copy link

(created using eb --new-pr)
Add libffi and elfutils as dependencies

@bowentan bowentan changed the title {compiler}[foss/2020b,2021b] Clang v11.0.1, v12.0.1 {compiler}[GCCcore/10.2.0, 11.2.0] Clang v11.0.1, v12.0.1 Jul 30, 2022
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (as discussed in slack, this was pretty clear cut; libomptarget.* dynamically links to both libffi and libelf)

@Micket Micket added the bug fix label Jul 31, 2022
@Micket Micket added this to the next release (4.6.1?) milestone Jul 31, 2022
@Micket
Copy link
Contributor

Micket commented Aug 1, 2022

Test report by @Micket
SUCCESS
Build succeeded for 4 out of 4 (2 easyconfigs in total)
alvis-s1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) Silver 4314 CPU @ 2.40GHz, Python 3.6.8
See https://gist.github.com/eca7d5935f8a6db1035dec7c6bb5a013 for a full test report.

@Micket
Copy link
Contributor

Micket commented Aug 1, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=15935 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15935 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8930

Test results coming soon (I hope)...

- notification for comment with ID 1201207610 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f7aa9298ee64669ec086bf12daecab94 for a full test report.

@Micket
Copy link
Contributor

Micket commented Aug 2, 2022

Going in, thanks @bowentan!

@Micket Micket merged commit f46a79f into easybuilders:develop Aug 2, 2022
@boegel boegel changed the title {compiler}[GCCcore/10.2.0, 11.2.0] Clang v11.0.1, v12.0.1 add libffi and elfutils as dependency for Clang v11.0.1 + v12.0.1 Aug 3, 2022
@zdemat
Copy link
Contributor

zdemat commented Aug 29, 2022

@bowentan and @Micket

can Clang-11.0.1-gcccuda-2020b.eb be fixed as well? It provides NVPTX target in addition.

@boegel
Copy link
Member

boegel commented Sep 9, 2022

I've made this fix consistent in recent Clang easyconfigs in #16225

@zdemat
Copy link
Contributor

zdemat commented Sep 9, 2022

@boegel Then I am interested in the test result of #16225 for Clang11.0.1 as I reported a possible issue with the easyblock: fix sanity checks for Clang 11 when built with NVPTX support easyblocks/#2782

@boegel
Copy link
Member

boegel commented Sep 9, 2022

@zdemat I'll keep an eye out for that, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants