Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify -DPython_ROOT configure option for GDAL 3.6.2 to make sure that Python dependency is used #17560

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Mar 18, 2023

(created using eb --new-pr)

Without this GDAL Python library is not built - see #17200 (comment)

@branfosj
Copy link
Member Author

@boegelbot please test @ jsc-zen2

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0104u04b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/6c9e98b9ac4f1a01d20f1ea4ba35dd9a for a full test report.

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17560 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17560 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2382

Test results coming soon (I hope)...

- notification for comment with ID 1474812440 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u12a.bear.cluster - Linux Ubuntu 20.04.2 LTS (Focal Fossa), x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/977eaf80b38e6216d01ba4250766e4ed for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/24dbfbe605fe8754b5856ae014e5ac50 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 18, 2023

@branfosj How did the sanity check pass if the Python library was missing? 🤔

@boegel boegel added this to the 4.7.1 milestone Mar 18, 2023
@branfosj
Copy link
Member Author

@branfosj How did the sanity check pass if the Python library was missing? thinking

For others it must be correctly detecting the Python to use (i.e. the EB installed one), which means it then finds the right libraries (i.e. numpy). For me it was detecting the Python from the venv I have EB installed in and this does not provide all the requirements for GDAL to build the Python libraries.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 18, 2023

@boegelbot please test @ generoso
EB_ARGS="--installpath /tmp/$USER/pr17560"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17560 EB_ARGS="--installpath /tmp/$USER/pr17560" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17560 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10503

Test results coming soon (I hope)...

- notification for comment with ID 1474824229 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Mar 18, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3133.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/b85425c0c7539c97f31054a287b38b4a for a full test report.

@boegel
Copy link
Member

boegel commented Mar 18, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit f0e50a4 into easybuilders:develop Mar 18, 2023
@branfosj branfosj deleted the 20230318105507_new_pr_GDAL362 branch March 18, 2023 12:03
@boegel
Copy link
Member

boegel commented Mar 18, 2023

@branfosj I guess we should apply the same fix to other recent GDAL easyconfigs?

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e01b55dcee515357bd827d3ebb61d987 for a full test report.

@boegel boegel changed the title specify Python_ROOT for GDAL 3.6.2 specify -DPython_ROOT configure option for GDAL 3.6.2 to make sure that Python dependency is used Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants