{math}[foss/2022a] MXNet 1.9.1 w/ Python 3.10.4 #18251
Conversation
deniskristak
changed the title
| { | ||
| 'download_filename': '5818c40f07bdb6307f9bc64e929836fe036da644.tar.gz', | ||
| 'filename': 'mkldnn.tar.gz' | ||
| } |
There was a problem hiding this comment.
Please use the 'source_urls' for this particular source dict and remove it from the gllobal source_urls.
There was a problem hiding this comment.
@Micket since there are a lot of different source urls, what is the benefit of letting easybuild find the correct combination of source url and source name rather than providing it all very specifically the way I tried to do? or is it just a thing of convention? i've fixed it according to your note, but I'm just interested
| description = """Flexible and Efficient Library for Deep Learning""" | ||
|
|
||
| toolchain = {'name': 'foss', 'version': '2022a'} | ||
| toolchainopts = {'cstd': 'c++14', 'opt': True, 'pic': True, 'openmp': True, 'extra_cflags': '-lflexiblas'} |
There was a problem hiding this comment.
To be still need extra manual cflags here despite including the patch to their cmakelists to support flexiblas?
There was a problem hiding this comment.
yep, won't build without it
There was a problem hiding this comment.
Then i wonder what good
list(APPEND mshadow_LINKER_LIBS ${BLAS_LIBRARIES})
does in the patch. If anything, I think the easyblock should fix this, or the patch
There was a problem hiding this comment.
you're right, this doesn't have to be in patch, removing...
There was a problem hiding this comment.
well, i don't think there is any advantage to modifying the patch. i'm mostly curious as to where it fails
There was a problem hiding this comment.
@Micket I think it's working now as is, but if you want, we could move the -lflexiblas option from extra_cflags in easyconfig to the easyblock somehow, however, I am not sure how to modify toolchainopts in easyblock...if you think it might be better that way, maybe drop me a hint about how to do that?
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1665337414 processed Message to humans: this is just bookkeeping information for me, |
There was a problem hiding this comment.
@deniskristak Unused patch mxnet-fix_blas.patch can be removed?
| toolchain = {'name': 'foss', 'version': '2022a'} | ||
| toolchainopts = {'cstd': 'c++14', 'opt': True, 'pic': True, 'openmp': True, 'extra_cflags': '-lflexiblas'} | ||
|
|
||
| # MXNet pulls in a bunch of submodules with specific commits |
There was a problem hiding this comment.
add comment to mention source for these commit IDs: https://github.com/apache/mxnet/tree/1.9.1/3rdparty
|
Test report by @boegelbot |
|
@boegelbot please test @ jsc-zen2 |
|
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1681797437 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegel |
|
Test report by @boegelbot |
|
Going in, thanks @deniskristak! |
adding easyconfigs: MXNet-1.9.1-foss-2022a.eb and patches: mxnet-fix_blas.patch
this is a dependency for vscentrum/vsc-software-stack#89