Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/12.3.0] maturin v1.1.0 + switch to CargoPythonPackage in existing maturin easyconfig #18596

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

casparvl
Copy link
Contributor

(created using eb --new-pr)

…goPythonPackage, since it's build with Rust
@casparvl
Copy link
Contributor Author

Test report by @casparvl
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/2eca40f02c73987acbf2214547099ab5 for a full test report.

@casparvl
Copy link
Contributor Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=18596 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18596 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11515

Test results coming soon (I hope)...

- notification for comment with ID 1685985463 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/05a9c6e328fc413895a2d702b1c0d38f for a full test report.

@casparvl
Copy link
Contributor Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18596 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18596 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3209

Test results coming soon (I hope)...

- notification for comment with ID 1686083657 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/c2f2777ed357fe5c3ba694c9380daf6d for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Aug 22, 2023

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.7, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/64b6d1578b9f56be9bdc84a5b6a5d2e8 for a full test report.

casparvl added a commit to sara-nl/easybuild-easyconfigs that referenced this pull request Aug 22, 2023
This PR depends on easybuilders#18596
Shouldn't re-add this
@Micket Micket added this to the next release (4.8.1?) milestone Aug 22, 2023
@Micket
Copy link
Contributor

Micket commented Aug 22, 2023

Going in, thanks @casparvl!

@Micket Micket merged commit 1097e00 into easybuilders:develop Aug 22, 2023
@boegel boegel changed the title Add new maturin for GCCcore 12.3.0 and change existing one to use CargoPythonPackage, since it's build with Rust {tools}[GCCcore/12.3.0] maturin v1.1.0 + switch to CargoPythonPackage in existing maturin easyconfig Aug 24, 2023
@boegel boegel added the bug fix label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants