Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OpenBLAS 0.3.20+ on newer Intel CPUs #19159

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Nov 6, 2023

(created using eb --new-pr)

This includes OpenMathLib/OpenBLAS#4287 as a patch after the cause for the failures were found, see OpenMathLib/OpenBLAS#4282 (comment)

Fixes #19021 and completes Sapphire Rapids support after #19141

@robert-mijakovic please give this a try too.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
n1501 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/270884c9478510cad2e79e91060b8cac for a full test report.

@Micket Micket added the bug fix label Nov 6, 2023
@Micket Micket added this to the next release (4.9.0?) milestone Nov 6, 2023
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Nov 6, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=19159 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19159 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12110

Test results coming soon (I hope)...

- notification for comment with ID 1795639833 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Contributor

Micket commented Nov 6, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19159 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19159 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3687

Test results coming soon (I hope)...

- notification for comment with ID 1795691681 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/ab92fae20bd5cc9978bf72a071d3d0c8 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/9c7b7e777f2ec42260dbe67754519819 for a full test report.

@Micket Micket merged commit c757d75 into easybuilders:develop Nov 7, 2023
9 checks passed
@Flamefire Flamefire deleted the 20231106133537_new_pr_OpenBLAS0320 branch November 7, 2023 17:55
@boegel boegel changed the title fix OpenBLAS on newer Intel CPUs fix OpenBLAS 0.3.20+ on newer Intel CPUs Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenBLAS build fails on Sapphire Rapids due to "Too many LAPACK tests failed"
3 participants