-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patch for GCC 12.x to fix miscompiling C++ code causing double-free in case of exceptions #19253
add patch for GCC 12.x to fix miscompiling C++ code causing double-free in case of exceptions #19253
Conversation
Test report by @schiotz |
Test report by @Flamefire |
Test report by @Flamefire |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
I can add to the test reports above that this actually fixed the issue that needed a workaround in PyTorch (in PR #19184). |
And I can confirm that the example C++ reproducer I created for GCC report works (only) after this :) |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1817537483 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ jsc-zen2 |
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1817543209 processed Message to humans: this is just bookkeeping information for me, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegelbot |
Test report by @boegelbot |
Test report by @boegel |
Going in, thanks @Flamefire! |
(created using
eb --new-pr
)