-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{ai}[foss/2023b] PyTorch v2.1.2 #20171
{ai}[foss/2023b] PyTorch v2.1.2 #20171
Conversation
Don't we want to start working with pytorch 2.2? |
Indeed. However with #20156 we have just fixed the tests for this version so I started porting this to 2023b and see if anything goes wrong. If not, we can update to 2.2.1 and see what new stuff breaks there. I had bad experiences with updating the version and the toolchain at the same time |
e36d1ac
to
e481b06
Compare
Test report by @casparvl |
@boegelbot please test @ generoso |
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2014681873 processed Message to humans: this is just bookkeeping information for me, |
So, the three errors I see are all of the form:
I'm not sure if that's something you recognize. It might be an issue on our system though: since recently, we have an issue with a memory leak in the kernel :\ |
Also, even though this counts as three failures, they all seem to be identical, just in different test files. So... I'm actually not to concerned with this - I consider it to be one failure, note three, and there's a reasonable chance it's due to our kernel. |
Just to double check: do you recognize this error @Flamefire ? |
Doesn't ring a bell for me. I'll (re)start the tests for this on our systems and if I don't see it on either I'd either increase the number of allowed failures or leave it to your site to ignore it. |
@boegelbot please test @ jsc-zen3 |
@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2014990327 processed Message to humans: this is just bookkeeping information for me, |
Ok. Either way is fine by me btw. Let's see how things go on the test clusters. If those pass with the current amount of |
Test report by @Flamefire |
Test report by @boegelbot |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Going in, thanks @Flamefire! |
Test report by @Flamefire |
(created using
eb --new-pr
)