Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[GCC/7.3.0-2.30] medaka v0.11.4 w/ Python 3.6.6 #9705

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 17, 2020

(created using eb --new-pr)

I'm forced to use an older toolchain here, since the latest version of medaka has some fairly strict version requirements, i.e.:

The test suite that is available in 'medata/test' in https://github.com/nanoporetech/medaka, which you can run with 'pytest medaka', passes fully (189 tests passed, no errors/failures).
I can't run the tests in the easyconfig though, since 'medaka/test' is not included in the release provided on PyPI, and using the sources straight from GitHub is not an option either since then the files in medaka/data are just stubs rather than the actual files (which are pulled in with git-lfs on 'git clone')... See also the discussion in nanoporetech/medaka#125.

@boegel
Copy link
Member Author

boegel commented Jan 17, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/74e1024df5f2fe22468e0e9e6b3598b8 for a full test report.

@boegel
Copy link
Member Author

boegel commented Jan 17, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2463.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/31403573c91a4c773609dc1c8be00e06 for a full test report.

@boegel boegel added this to the 4.x milestone Jan 21, 2020
@easybuilders easybuilders deleted a comment from boegelbot Jan 21, 2020
@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, AMD EPYC 7601 32-Core Processor, Python 2.7.5
See https://gist.github.com/41bd7f94564f02f62de1cb3835fd95f7 for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit da75517 into easybuilders:develop Feb 4, 2020
@boegel boegel deleted the 20200117175031_new_pr_medaka0114 branch February 6, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants